Conversation
str4d
reviewed
Mar 31, 2026
nullcopy
force-pushed
the
feat/z_importaddress
branch
from
7d73197 to
ce67aa1
Compare
Contributor
Author
|
Force-pushed ef21adc to rebase onto librustzcash dependency bumps |
nullcopy
force-pushed
the
feat/z_importaddress
branch
from
ce67aa1 to
7fd5d6a
Compare
Contributor
Author
nuttycom
approved these changes
Apr 1, 2026
Contributor
nuttycom
left a comment
nuttycom
left a comment
There was a problem hiding this comment.
utACK with nonblocking comments.
Add the `z_importaddress` RPC method, which accepts a hex-encoded public key (P2PKH) or redeem script (P2SH) and imports the corresponding transparent address into the wallet. After import it optionally rescans for UTXOs belonging to all wallet transparent addresses.
nullcopy
force-pushed
the
feat/z_importaddress
branch
from
7fd5d6a to
bd7e7bb
Compare
Contributor
Author
|
Force-pushed to improve misleading error message |
nuttycom
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
z_importaddressfor standalone P2PKH and P2SH address import. I didn't see an existing implementation ofz_importaddressin zcashd, so I tried to use my best judgement when designing it here.The commit patches librustzcash to use the latest commit, which supports the new standalone P2SH address import API.
Supercedes #399
Resolves #272
Resolves COR-326